add enzyme to AD tests #505
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
===========================================
- Coverage 94.16% 31.31% -62.85%
===========================================
Files 52 52
Lines 1387 1373 -14
===========================================
- Hits 1306 430 -876
- Misses 81 943 +862 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…elFunctions.jl into st/enzyme_ad
theogf
reviewed
May 3, 2023
| # f_prime(flatargs) = f(reshape(flatargs, shape...)) | ||
| # return Enzyme.gradient(Enzyme.Reverse, f_prime, reshape(args, prod(shape))) | ||
| d_args = zero(args) | ||
| Enzyme.autodiff(Enzyme.Reverse, f, Enzyme.Active, Enzyme.Duplicated(args, d_args)) |
There was a problem hiding this comment.
I don't think you need the Enzyme.Active but not sure...
|
I think it's worth re-running these tests. I just did a bunch of tests myself (not this PR though) and most kernels seem to work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed changes
What alternatives have you considered?
Breaking changes